[FLINK-9765] [sql-client] Improve CLI responsiveness when cluster is not reachable #6265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 |
1 similar comment
Contributor
|
+1 |
Contributor
Author
asfgit
pushed a commit
that referenced
this pull request
Jul 24, 2018
…not reachable Moves the job cancellation into the final phase of the refresh thread in order to keep the CLI responsive. This closes #6265.
asfgit
pushed a commit
that referenced
this pull request
Jul 24, 2018
…not reachable Moves the job cancellation into the final phase of the refresh thread in order to keep the CLI responsive. This closes #6265.
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
…not reachable Moves the job cancellation into the final phase of the refresh thread in order to keep the CLI responsive. This closes apache#6265.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Moves the job cancellation into the final phase of the refresh thread in order to keep the CLI responsive. The result of the cancellation is not used anyway.
Brief change log
Moves the job cancellation into the phase of the refresh thread
Verifying this change
Manually verified.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation