Skip to content

Conversation

@GJL
Copy link
Member

@GJL GJL commented Jul 25, 2018

What is the purpose of the change

Not killing Flink processes at the end of a test, can cause interference with subsequent test runs.

Brief change log

  • Kill Flink processes in DB/teardown!.

Verifying this change

This change added tests and can be verified as follows:

  • Ran tests in docker.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

cc: @tillrohrmann

@GJL GJL changed the title [FLINK-9949][tests] Kill Flink processes in DB/teardown [FLINK-9949][tests] Kill Flink processes in DB/teardown! Jul 25, 2018
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging this PR.

asfgit pushed a commit that referenced this pull request Jul 25, 2018
@asfgit asfgit closed this in ea10b07 Jul 25, 2018
sampathBhat pushed a commit to sampathBhat/flink that referenced this pull request Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants