Skip to content

[FLINK-9987][tests] Harden ClassLoader E2E test #6442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zentol merged 2 commits into from
Jul 31, 2018
Merged

[FLINK-9987][tests] Harden ClassLoader E2E test #6442

zentol merged 2 commits into from
Jul 31, 2018

Conversation

@zentol
Copy link
Contributor

@zentol zentol commented Jul 27, 2018

What is the purpose of the change

This PR hardens the ClassLoader end-to-end test.

Brief change log

  • retrieve commit id from .version.properties as the value has a well-defined format
  • do not access .version.properties file in source of flink-runtime and match id against regex instead
    • prevents failures caused by value mismatches if the binary does not originate from the source
    • prevents failures when flink-runtime has not been built, e.g. if the tests were run in a clean repo
    • removes access outside of flink-end-to-end-tests which is good for maintainability
  • exit early on test failure
    • same behavior as if the test was split in several files

@zentol zentol requested a review from aljoscha July 27, 2018 16:27
@zentol zentol mentioned this pull request Jul 27, 2018
Merged
twalthr
twalthr requested changes Jul 31, 2018
View reviewed changes
Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zentol. I had just a little comment. Otherwise +1 to merge.

...classloading-test/src/main/java/org/apache/flink/streaming/tests/ClassLoaderTestProgram.java Outdated
Properties properties = new Properties();
properties.load(in);
String orderedGitUrl = properties.getProperty("git.remote.origin.url");
String orderedGitUrl = properties.getProperty("git.commit.id.abbrev");
Copy link
Contributor

@twalthr twalthr Jul 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update variable name as well.

@zentol zentol merged commit a9d556e into apache:master Jul 31, 2018
@zentol zentol deleted the 9987 branch July 31, 2018 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twalthr twalthr twalthr requested changes

@aljoscha aljoscha Awaiting requested review from aljoscha

Assignees

No one assigned

Labels

component=Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zentol @twalthr @rmetzger