[FLINK-10051][tests][sql] Add missing depenendeices for sql client E2E test #6486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 |
twalthr
approved these changes
Aug 6, 2018
| <artifactId>scala-compiler</artifactId> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> |
Contributor
There was a problem hiding this comment.
nit: Add a comment that a new jar has to be added here and in the bottom section.
flinkbot
added
component=TableSQL/API
component=TableSQL/Client
and removed
component=API/TableSQL
component=SQL/Client
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR adds missing dependencies to the sql-client end-to-end test.
The sql-client end-to-end test uses the dependency-plugin to copy a few jars into the /target directory. However since the module doesn't define dependencies on these jars there's no guarantee that these jars are built before the test, or even at all. This caused the tests to fail, since the kafka 0.11 connector wasn't at all and also wasn't available in the SNAPSHOT repository.
Brief change log
add dependencies for all kafka connectors, avro and json.
Verifying this change
flink-ci build: https://travis-ci.org/zentol/flink-ci/builds/411803521
I modified the flink version to guard against the issue being obfuscated by existing SNAPSHOT artifacts.