Skip to content

Some fixes for Scala type analysis #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aljoscha wants to merge 3 commits into from
Closed

Some fixes for Scala type analysis #669

aljoscha wants to merge 3 commits into from

Conversation

@aljoscha
Copy link
Contributor

@aljoscha aljoscha commented May 12, 2015

No description provided.

@aljoscha aljoscha mentioned this pull request May 12, 2015
Closed
@aljoscha aljoscha force-pushed the scala-type-analysis-fix branch 3 times, most recently from ef620b9 to f746dec Compare May 13, 2015 12:04
@aljoscha
Copy link
Contributor Author

aljoscha commented May 18, 2015

Any comments? Do we want this?

@aljoscha aljoscha force-pushed the scala-type-analysis-fix branch from f746dec to 7b5f832 Compare May 20, 2015 16:53
@vasia
Copy link
Contributor

vasia commented May 21, 2015

Hey @aljoscha,
it seems this is one needed for the Gelly Scala API :-)
Shall I go ahead and merge it?

@aljoscha
Copy link
Contributor Author

aljoscha commented May 21, 2015

I didn't want to merge it without any comments. But please, go ahead. 😄

@StephanEwen
Copy link
Contributor

StephanEwen commented May 21, 2015

It would be good to share a bit of information beyond Some fixes for Scala type analysis about what is actually changed. Then others could think about possible implications and give comments.

@aljoscha
Copy link
Contributor Author

aljoscha commented May 21, 2015

This excludes static fields in Scala Pojo analysis (because static fields should not be serialised/deserializerd), removes legacy code from Scala Type Descriptors and makes Scala Type Analysis work with Java Tuples (because several people complained about them not being supported in the Scala API, most prominently they are needed to port Gelly to Scala.)

@StephanEwen
Copy link
Contributor

StephanEwen commented May 21, 2015

Looks reasonable.

Will merge this with the next batch...

@vasia
Copy link
Contributor

vasia commented May 21, 2015

Thanks :)

@asfgit asfgit closed this in f8a381f May 21, 2015
@aljoscha aljoscha deleted the scala-type-analysis-fix branch May 21, 2015 20:42
marthavk pushed a commit to marthavk/flink that referenced this pull request Jun 9, 2015
@aljoscha @marthavk
[FLINK-2023] [scala] Improve type analysis
3e06a03 
 - Exclude static fields in Scala Pojo analysis
 - Recognize Java Tuples
 - Clean up legacy code

(And also make one of the field type retrieval methods nicer)

This closes apache#669
nltran pushed a commit to nltran/flink that referenced this pull request Jan 8, 2016
@aljoscha
[FLINK-2023] [scala] Improve type analysis
9696633 
 - Exclude static fields in Scala Pojo analysis
 - Recognize Java Tuples
 - Clean up legacy code

(And also make one of the field type retrieval methods nicer)

This closes apache#669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aljoscha @vasia @StephanEwen