Skip to content

Conversation

@zhijiangW
Copy link
Contributor

What is the purpose of the change

There are currently existing two same NoOpResultPartitionConsumableNotifier. We should retain only one and unify all the usages in related tests for avoiding mock.

Brief change log

  • Keep only one NoOpResultPartitionConsumableNotifier for tests
  • Modify all the related tests to avoid mock ResultPartitionConsumableNotifier

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@zhijiangW zhijiangW force-pushed the FLINK-10607 branch 2 times, most recently from d56cefe to bc113ac Compare October 22, 2018 08:24
Copy link
Contributor

@pnowojski pnowojski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pnowojski pnowojski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnowojski pnowojski merged commit 7311f01 into apache:master Oct 22, 2018
@zhijiangW zhijiangW deleted the FLINK-10607 branch October 22, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants