[FLINK-10665] [tests] Remove legacy test YARNSessionFIFOITCase#testJavaAPI

[tisonkun]

What is the purpose of the change

Remove legacy test YARNSessionFIFOITCase#testJavaAPI. Since the functions are covered by DefaultCLITest

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with (Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (not applicable)

cc @tillrohrmann

[zentol]

14:45:49.851 [INFO] There are 3 errors reported by Checkstyle 8.9 with /tools/maven/checkstyle.xml ruleset.
14:45:49.852 [ERROR] src/test/java/org/apache/flink/yarn/YARNITCase.java:[127] (javadoc) JavadocType: Missing a Javadoc comment.
14:45:49.852 [ERROR] src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java:[38] (imports) ImportOrder: Import org.apache.flink.yarn.util.YarnTestUtils appears after other imports that it should precede
14:45:49.852 [ERROR] src/test/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java:[39] (imports) ImportOrder: 'org.apache.hadoop.fs.Path' should be separated from previous imports.

[tisonkun]

@zentol thanks for the review, add a hotfix :-)

[zentol]

20:26:56.337 [INFO] --- maven-checkstyle-plugin:2.17:check (validate) @ flink-yarn-tests_2.11 ---
20:26:56.533 [INFO] There is 1 error reported by Checkstyle 8.9 with /tools/maven/checkstyle.xml ruleset.
20:26:56.534 [ERROR] src/test/java/org/apache/flink/yarn/YARNITCase.java:[31,8] (imports) UnusedImports: Unused import: org.apache.flink.streaming.api.functions.source.ParallelSourceFunction.

[tisonkun]

@zentol thanks and sorry I should have paid more attention

[tisonkun]

@zentol I have resolved travis issue. Could you review this when you're free? There are little changes though.

[tisonkun]

cc @GJL would you like to give a glance at this thread? it's not quite complex imo.

[GJL]

How about we delete testJavaAPI? This test only starts a session cluster and tests whether the ClusterConnectionInfo and the URL of the web UI are not null. I don't see how this is related to Yarn's FIFO scheduler, i.e., the test does not belong here. Retrieving the ClusterConnectionInfo and URL of the web ui is already covered by other tests [1][2]. Lastly, the ported version in this PR does not have the same assertions as before. Let me know what you think, @tisonkun.

[1]

flink/flink-clients/src/test/java/org/apache/flink/client/cli/DefaultCLITest.java

Line 71 in 0a54983

final LeaderConnectionInfo clusterConnectionInfo = clusterClient.getClusterConnectionInfo();

[2] https://github.com/apache/flink/blob/0a54983ca0207444477cfe991dbee1b611496204/flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java

[tisonkun]

Thanks for your investigation. I've checkout it and agree with you, adding a follow-up to address your comment.

As a following consideration, we should properly test FLINK on YARN in the future. Current status is not quite robust and elegant IMO (ó﹏ò｡)