Skip to content

Conversation

@StephanEwen
Copy link
Contributor

What is the purpose of the change / Brief change log

Fixes the duplication of the Scala EitherSerialzer that never deep copies, even though the nested serializers might require it.

Verifying this change

  • Adds a self-contained unit test

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: yes
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@StephanEwen
Copy link
Contributor Author

CI test failure is unrelated:
FlinkKafkaProducerITCase.testFlinkKafkaProducer10FailTransactionCoordinatorBeforeNotify -Timeout

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @StephanEwen. LGTM. I think this fix should also be backported to release-1.6 and release-1.5.

@tillrohrmann
Copy link
Contributor

I'll backport this PR to release-1.5 and release-1.6. If Travis passes, then I'll merge it.

tillrohrmann pushed a commit to tillrohrmann/flink that referenced this pull request Oct 31, 2018
tillrohrmann pushed a commit to tillrohrmann/flink that referenced this pull request Oct 31, 2018
tillrohrmann pushed a commit to tillrohrmann/flink that referenced this pull request Oct 31, 2018
tillrohrmann pushed a commit to tillrohrmann/flink that referenced this pull request Oct 31, 2018
tillrohrmann pushed a commit to tillrohrmann/flink that referenced this pull request Oct 31, 2018
@asfgit asfgit closed this in 68df7f9 Nov 1, 2018
JTaky pushed a commit to JTaky/flink that referenced this pull request Dec 26, 2018
ashangit pushed a commit to criteo-forks/flink that referenced this pull request Dec 31, 2018
tisonkun pushed a commit to tisonkun/flink that referenced this pull request Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants