-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-10693] [Scala API] Fix incorrect duplication in EitherSerializer #6951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI test failure is unrelated: |
tillrohrmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @StephanEwen. LGTM. I think this fix should also be backported to release-1.6 and release-1.5.
|
I'll backport this PR to |
What is the purpose of the change / Brief change log
Fixes the duplication of the Scala
EitherSerialzerthat never deep copies, even though the nested serializers might require it.Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation