[FLINK-10364][tests] Fix instability in NonHAQueryableStateFsBackendI… #6975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TCase#testMapState
kl0u
approved these changes
Nov 5, 2018
Contributor
kl0u
left a comment
kl0u
left a comment
There was a problem hiding this comment.
Thanks for the work @StefanRRichter ! This definitely avoids the NPE so +1 to merge, but given that we do future.get(deadline.timeLeft().toMillis(), TimeUnit.MILLISECONDS), the NPE will become an assertion error because we did not manage to get the value within the timeout, right? This is because of the while (deadline.hasTimeLeft() && !success) {...}.
Contributor
Author
|
Thanks for the review @kl0u. I think the NPE can be caused by some consistency/visibility problem that I think can happen in queryable state, so giving it a retry will probably yield a successful result eventually. Merging. |
asfgit
pushed a commit
that referenced
this pull request
Nov 5, 2018
…TCase#testMapState This closes #6975.
asfgit
pushed a commit
that referenced
this pull request
Nov 5, 2018
…TCase#testMapState This closes #6975.
JTaky
pushed a commit
to JTaky/flink
that referenced
this pull request
Dec 26, 2018
…TCase#testMapState This closes apache#6975.
ashangit
pushed a commit
to criteo-forks/flink
that referenced
this pull request
Dec 31, 2018
…TCase#testMapState This closes apache#6975.
tisonkun
pushed a commit
to tisonkun/flink
that referenced
this pull request
Jan 17, 2019
…TCase#testMapState This closes apache#6975.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…TCase#testMapState
What is the purpose of the change
This PR fixes a potential NPE in
AbstractQueryableStateTestBase#testMapStateby extending the condition to retry the query under test.