[BP-1.7][FLINK-10772][release] Fix create_binary_release.sh #7017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the unnecessary call to change_scala_version.sh and remove the -Dmaven.test.skip=true property. The latter is necessary because this property suppresses the compilation and packaging of test classes. It, however, does not suppress the resolution of test dependencies which will then fail to compile because test dependencies have not been built. This commit also removes the redundant call to build flink-shaded/hadoop/flink-shaded-hadoop2-uber which is a dependency of flink-dist anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7016 to
release-1.7.