[FLINK-10797] "IntelliJ Setup" link is broken in README.md #7025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the correct link of docs/flinkDev/ide_setup.md#intellij-idea Change-Id: I293b3ed51e5fa54046d1a97614f02e31c93fc899
shaoxuan-wang
approved these changes
Nov 6, 2018
Contributor
shaoxuan-wang
left a comment
shaoxuan-wang
left a comment
There was a problem hiding this comment.
Thanks for correcting the broken link. I will merge the change.
Member
|
@shaoxuan-wang regardless the duplication of this pr(#7025 ) and #7024 I'd like to point out two concerns on this thread.
x. there is another incorrect path of "IntelliJ Setup" in |
Contributor
Thanks @tisonkun . I did not notice there is an existing PR. @xndai can you please close this PR as #7024 already addressed problem reported in FLINK-10797 |
Author
|
Didn't know there's an existing PR either. Will close this one. |
shaoxuan-wang
pushed a commit
to shaoxuan-wang/flink
that referenced
this pull request
Nov 8, 2018
Use the correct link of docs/flinkDev/ide_setup.md#intellij-idea Change-Id: I293b3ed51e5fa54046d1a97614f02e31c93fc899 This closes apache#7025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the correct link of docs/flinkDev/ide_setup.md#intellij-idea
Change-Id: I293b3ed51e5fa54046d1a97614f02e31c93fc899