Skip to content

Conversation

@tzulitai
Copy link
Contributor

@tzulitai tzulitai commented Nov 7, 2018

What is the purpose of the change

This PR is based on top of #7041. Only the last commit relevant.

This PR extends coverage of our all-round DataStream end-to-end test job to have operators with input types that goes through Kryo serialization:

  • Without the data type registered
  • With the data type registered
  • With the data type registered, also with a custom Kryo serializer

Verifying this change

All end-to-end tests should still pass with the change.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

@zentol zentol changed the title Flink 9001 [FLINK-9002] [e2e] Add operators with input tyoe that goes through Avro serialization Nov 7, 2018
@zentol zentol changed the title [FLINK-9002] [e2e] Add operators with input tyoe that goes through Avro serialization [FLINK-9002] [e2e] Add operators with input type that goes through Avro serialization Nov 7, 2018
@dawidwys dawidwys changed the title [FLINK-9002] [e2e] Add operators with input type that goes through Avro serialization [FLINK-9001] [e2e] Add operators with input type that goes through Kryo serialization Nov 8, 2018
@twalthr twalthr self-assigned this Nov 8, 2018
Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tzulitai. I added one comment.

in -> new GenericKryoEvent(in.getKey(), in.getEventTime(), in.getSequenceNumber(), in.getPayload()),
in -> new Event(in.getKey(), in.getEventTime(), in.getSequenceNumber(), in.getPayload()),
GenericKryoEvent::getKey,
"Kryo (Generic)");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also pass the expected serializer class to this method or some validation lambda that takes the serializer such that we can perform some validation to make sure we are testing the right thing?

@twalthr
Copy link
Contributor

twalthr commented Dec 4, 2018

@tzulitai any news here?

@tillrohrmann
Copy link
Contributor

Close as abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants