[FLINK-2084] [core] Add an option to start Flink in streaming mode #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and release memory as needed. This is an alternative mode to the current mode that pre-allocates all memory. The default remains to pre-allocate all memory.
- Streaming mode sets the memory manager to lazy memory allocation to ensure heap is not blocked by batch memory manager
StephanEwen
force-pushed
the
streaming_mode
branch
from
1df1f12 to
64e9b36
Compare
| @@ -80,7 +81,7 @@ case $STARTSTOP in | |||
| rotateLogFile $out | |||
|
|
|||
| echo "Starting Job Manager" | |||
| $JAVA_RUN $JVM_ARGS ${FLINK_ENV_JAVA_OPTS} "${log_setting[@]}" -classpath "`manglePathList "$FLINK_JM_CLASSPATH:$INTERNAL_HADOOP_CLASSPATHS"`" org.apache.flink.runtime.jobmanager.JobManager --executionMode $EXECUTIONMODE --configDir "$FLINK_CONF_DIR" > "$out" 2>&1 < /dev/null & | |||
| $JAVA_RUN $JVM_ARGS ${FLINK_ENV_JAVA_OPTS} "${log_setting[@]}" -classpath "`manglePathList "$FLINK_JM_CLASSPATH:$INTERNAL_HADOOP_CLASSPATHS"`" org.apache.flink.runtime.jobmanager.JobManager --configDir "$FLINK_CONF_DIR" --executionMode $EXECUTIONMODE --streamingMode "$STREAMINGMODE" > "$out" 2>&1 < /dev/null & | |||
Contributor
There was a problem hiding this comment.
With this change, the script now expects three arguments, right?
If you, you need to update this line as well
echo "Please specify 'start (cluster|local)' or stop"
Contributor
Author
There was a problem hiding this comment.
Actually, the streaming mode parameter is optional and defaults to "batch".
Contributor
There was a problem hiding this comment.
Okay, sorry. I didn't see this.
Contributor
Author
There was a problem hiding this comment.
I'll add it anyways. It is a good hint.
Contributor
|
+1 to merge. |
|
|
||
| Assert.assertTrue("The previously allocated segments were not valid any more.", | ||
| allMemorySegmentsValid(segs)); | ||
|
|
Contributor
|
+1 looks solid. |
Contributor
Author
|
Thank you for the comments. I'll address them and merge this... |
marthavk
pushed a commit
to marthavk/flink
that referenced
this pull request
Jun 9, 2015
nltran
pushed a commit
to nltran/flink
that referenced
this pull request
Jan 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The streaming mode subsumes the batch mode, as it allows to run both kinds of programs. Batch programs will most likely run slightly less efficient than in pure batch mode, due to lazy memory allocation (see below)
Adds new startup options to the JobManager and TaskManager.
Adds additional scripts
bin/start-cluster-streaming.shandstart-local-streaming.sh.Currently, streaming mode only sets the memory manager to lazy memory allocation to ensure heap is not blocked by batch memory manager
Includes [FLINK-2085] To support on-demand memory allocation in the memory manager.