Skip to content

Conversation

@GJL
Copy link
Member

@GJL GJL commented Nov 30, 2018

What is the purpose of the change

Make sure Flink only allocates the necessary mesos ports. This PR is based on #6557

cc: @runesl

Brief change log

  • Remove default value for config option, and treat absence correctly.
  • See commits

Verifying this change

This change added tests and can be verified as follows:

  • Added unit test in LaunchableMesosWorkerTest

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@asfgit asfgit closed this in 529288d Dec 3, 2018
zentol pushed a commit to zentol/flink that referenced this pull request Dec 6, 2018
tisonkun pushed a commit to tisonkun/flink that referenced this pull request Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants