Skip to content

Conversation

@zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Dec 4, 2018

What is the purpose of the change

  • This PR fix the issue of unable to set number of task manager and slot per task manager in scala shell local mode.

Brief change log

I will set number of task manager and slot per task manager in FlinkShell via Configuration

Verifying this change

Verify it manually, set the following 2 properties in flink-conf.yaml, then start scala-shell in local mode and check the jm dashboard.

local.number-taskmanager: 2
taskmanager.numberOfTaskSlots: 8

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

…lot per task manager in scala shell local mode
@zjffdu
Copy link
Contributor Author

zjffdu commented Dec 11, 2018

@yanghua @tillrohrmann Could you help review it ? Thanks

Copy link
Contributor

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @zjffdu . LGTM.

@zjffdu
Copy link
Contributor Author

zjffdu commented Jan 9, 2019

@tillrohrmann @uce Could you help review it ? Thanks

@AHeise
Copy link
Contributor

AHeise commented Sep 28, 2021

Closing this PR due to https://issues.apache.org/jira/browse/FLINK-24360 / #17340

@AHeise AHeise closed this Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants