Skip to content

[hotfix][docs] Fix StreamingFileSink examples #7232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
igalshilman wants to merge 1 commit into from
Closed

[hotfix][docs] Fix StreamingFileSink examples #7232

igalshilman wants to merge 1 commit into from

Conversation

@igalshilman
Copy link
Contributor

@igalshilman igalshilman commented Dec 4, 2018

What is the purpose of the change

The code examples for Scala and Java are both syntactically broken, and set a bad example in terms of efficiency.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

[hotfix] Fixing the broken code examples
abe40e1 
The code examples for Scala and Java are both broken,
and set a bad example in terms of efficiency.
kl0u
kl0u approved these changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@kl0u kl0u left a comment •
edited by GJL
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GJL
GJL approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@GJL GJL left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kl0u
Copy link
Contributor

kl0u commented Dec 5, 2018

I am merging!

kl0u pushed a commit to kl0u/flink that referenced this pull request Dec 5, 2018
@kl0u
[hotfix] Fixing the broken code examples
2e72548 
The code examples for Scala and Java are both broken,
and set a bad example in terms of efficiency.

This closes apache#7232.
@asfgit asfgit closed this in 2e1cbf2 Dec 5, 2018
asfgit pushed a commit that referenced this pull request Dec 5, 2018
@kl0u
[hotfix] Fixing the broken code examples
0215f49 
The code examples for Scala and Java are both broken,
and set a bad example in terms of efficiency.

This closes #7232.
zentol pushed a commit to zentol/flink that referenced this pull request Dec 6, 2018
@zentol
[hotfix] Fixing the broken code examples
cdc0bfe 
The code examples for Scala and Java are both broken,
and set a bad example in terms of efficiency.

This closes apache#7232.
tisonkun pushed a commit to tisonkun/flink that referenced this pull request Jan 17, 2019
@tisonkun
[hotfix] Fixing the broken code examples
95a6728 
The code examples for Scala and Java are both broken,
and set a bad example in terms of efficiency.

This closes apache#7232.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GJL GJL GJL approved these changes

@kl0u kl0u kl0u approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igalshilman @kl0u @GJL