[FLINK-11083][Table&SQL] CRowSerializerConfigSnapshot is not instantiable #7267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzulitai
reviewed
Dec 11, 2018
Contributor
tzulitai
left a comment
tzulitai
left a comment
There was a problem hiding this comment.
Changes looks good, with one minor comment in the tests. Thanks for fixing this.
| new CRowSerializer.CRowSerializerConfigSnapshot() | ||
|
|
||
| val serializerConfigSnapshotClass = Class.forName( | ||
| "org.apache.flink.table.runtime.types.CRowSerializer$CRowSerializerConfigSnapshot") |
Contributor
There was a problem hiding this comment.
Can you use classOf[...] here?
Author
|
@tzulitai Thanks for the review. Have updated the PR to address your comment. |
Author
Contributor
|
Hi @kisimple there is already a committer taking care of this PR. You don't need to ping more people. |
Contributor
|
LGTM, merging this ... |
tzulitai
pushed a commit
to tzulitai/flink
that referenced
this pull request
Dec 17, 2018
…iable This closes apache#7267.
tzulitai
pushed a commit
to tzulitai/flink
that referenced
this pull request
Dec 17, 2018
…iable This closes apache#7267.
tzulitai
pushed a commit
to tzulitai/flink
that referenced
this pull request
Dec 18, 2018
…iable This closes apache#7267.
JTaky
pushed a commit
to JTaky/flink
that referenced
this pull request
Dec 26, 2018
…iable This closes apache#7267.
ashangit
pushed a commit
to criteo-forks/flink
that referenced
this pull request
Dec 31, 2018
…iable This closes apache#7267.
tisonkun
pushed a commit
to tisonkun/flink
that referenced
this pull request
Jan 17, 2019
…iable This closes apache#7267.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This patch adds an empty nullary constructor to
CRowSerializerConfigSnapshot.Brief change log
CRowSerializerConfigSnapshot.Verifying this change
This change added tests and can be verified as follows:
CRowSerializerTestto verify the change.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation