[FLINK-11151][rest] Create parent directories in FileUploadHandler #7300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhuw
reviewed
Dec 16, 2018
| currentHttpRequest = ReferenceCountUtil.retain(httpRequest); | ||
|
|
||
| // make sure that we still have a upload dir in case that it got deleted in the meanwhile | ||
| RestServerEndpoint.createUploadDir(uploadDir, LOG); |
Member
There was a problem hiding this comment.
Branch msg instanceof HttpContent && currentHttpPostRequestDecoder != null has this statement too. Seems that line is useless and can be deleted safely since following receiving work happens in currentUploadDir not its parent uploadDir. If uploadDir got deleted meanwhile, the upload request should fail due to potential lost of uploaded files, this is what will happen in fileUpload.renameTo(dest.toFile()).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
With this PR the FileUploadHandle checks that the upload directory still exists before accepting a request, and regenerates it if this isn't the case. This behavior is in sync with the handling of deleted upload directories during an upload (see the
msg instanceof HttpContentbranch).Previously, if the directory has been deleted, the handler would continuously fail in this situation.
Brief change log
RestServerEndpoint.createUploadDirbefore creating request-scoped directoryVerifying this change
This change added tests and can be verified as follows:
org.apache.flink.runtime.rest.FileUploadHandlerTest#testUploadDirectoryRegeneration