-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-11179][tests] add wait time for every record for testCancelSor… #7315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tMatchWhileDoingHeavySorting
…tMatchWhileDoingHeavySorting This closes apache#7315
|
|
||
| private static final class SimpleMatcher<IN> implements JoinFunction<Tuple2<IN, IN>, Tuple2<IN, IN>, Tuple2<IN, IN>> { | ||
| private static final long serialVersionUID = 1L; | ||
| private static final int WAIT_TIME_PER_RECORD = 300; // 0.3 sec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sunjincheng121 Thanks for reporting and fixing the problem. The test can pass with the fix. As for the changes, how about make delay configurable in DelayingMatcher? Keep SimpleMatcher as what it is, i.e, keep it simple.
Best, Hequn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Thanks for the review @hequn8128 !
If we using DelayingMatcher then we do not need this test case anymore. So I think both add the wait_time and make delayingMatcher are can not achieve the purpose of testing。 Because wait_time and delayingMatcher only test the join phase,we want test the sore-merge phase. So we should make sore-merge phase take more time to achieve the purpose of testing. I got a better approach,and will update the PR.
4d7d7b5 to
a754698
Compare
a754698 to
8bf0a38
Compare
|
Hi @hequn8128 I had update the PR. appreciate if you can look at it again! |
|
@sunjincheng121 Thanks for the update. The code is good. +1 to merge from my side. |
|
Thanks @hequn8128, will be merged as soon as CI passed. |
What is the purpose of the change
(test case bug fix: add wait time for every record for testCancelSortMatchWhileDoingHeavySorting.)
Brief change log
Verifying this change
This change is a test case bug fix.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation