[FLINK-4369] Optimize evict performance for the TriggerResult.FIRE_AND_PURGE #7344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the previous work around fix FLINK-4369. It will clear windowState then add the non-evicted elements in the state again. And if the triggerResult is FIRE_AND_PURGE, it will clear state twice. Add a boolean flag to avoid this behavior.
klion26
reviewed
Dec 25, 2018
...main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
Outdated
Show resolved
Hide resolved
added 3 commits
January 11, 2019 17:09
Refine triggerWindowContents's parameters placement.
|
This PR is being marked as stale since it has not had any activity in the last 180 days. If you are having difficulty finding a reviewer, please reach out to the [community](https://flink.apache.org/what-is-flink/community/). If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 90 days, it will be automatically closed. |
Collaborator
|
This PR has been closed since it has not had any activity in 120 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Due to the previous work around fix FLINK-4369.
It will clear windowState, then add the non-evicted elements in it again.
And if the triggerResult is FIRE_AND_PURGE, it will waste performance to clear state twice.
Brief change log
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation