Skip to content

[hotfix] [dispatcher] Improve signature of #waitForTerminatingJobManager#7355

Closed
tisonkun wants to merge 1 commit intoapache:masterfrom
tisonkun:GH-7355_
Closed

[hotfix] [dispatcher] Improve signature of #waitForTerminatingJobManager#7355
tisonkun wants to merge 1 commit intoapache:masterfrom
tisonkun:GH-7355_

Conversation

@tisonkun
Copy link
Member

What is the purpose of the change

#waitForTerminatingJobManager get a JobGraph, terminate the previous running future(if there was) and then apply a new action. The jobId should be always the same as jobGraph.getJobID(). We change the signature to improve understandability.

Brief change log

#waitForTerminatingJobManager(JobID, JobGraph, Function)#waitForTerminatingJobManager(JobGraph, Function), and the JobID is now generated by JobGraph

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

cc @tillrohrmann @StefanRRichter

@tisonkun tisonkun closed this Jan 17, 2019
@tisonkun tisonkun deleted the GH-7355_ branch January 17, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant