[hotfix][doc] fix error http port in elasticsearch scala doc #7361
Conversation
yanghua
left a comment
yanghua
left a comment
There was a problem hiding this comment.
@lamber-ken Thanks for your contribution. LGTM. The Kafka connector test timeout caused the travis failure. You can open a JIRA issue for that and rebuild your PR.
|
@yanghua, thanks for reviews. I'll use the git command which you teached before to rebuild pr 😄 |
|
@yanghua I've told you this before, don't rerun Travis for documentation changes. This is a completely unnecessary waste of resources. |
|
Please provide a source for 9200 being the correct port. |
sorry, I see. |
|
@zentol Sorry, I thought that if Travis turns green, it will make it easier for committer to merge PR, otherwise, they will need to confirm why it failed. And I have asked @lamber-ken to report this failed case to JIRA instead of ignoring it. Then next time I will not make this suggestion. |
hi, @zentol, here is official elasticsearch source doc, from official doc, we can konw default http is 9200, and give us a complete example |
|
Can confirm, 9200 is the correct port for the REST-based Elasticsearch 6.x connector. LGTM, will merge this ... One suggestion: it would have been easier to confirm this if the PR stated that the docs were incorrect only for the 6.x connector. |
Ok |
4 participants
What is the purpose of the change
fix error http port in elasticsearch scala doc.
http port is 9200, not 9300