Skip to content

Conversation

@mbalassi
Copy link
Contributor

This builds on #521 and fixes some issues in it:

  • The pull request was rebased
  • fromCollection and generateSequence and the parallel versions have the expected behaviour
  • Removed old Serializable unnecessary mentions from both the batch and streaming execution environments.

I consider this an 0.9 blocker.

@gyfora
Copy link
Contributor

gyfora commented May 28, 2015

Looks good , but we probably should modify (or add) some tests to test the newly added functions because I think none of the new functionality is tested properly.

@mbalassi
Copy link
Contributor Author

Thanks for the review. The test coverage is the following:

  • The newly introduced StreamExecutionEnvionmentTest is for testing the parallelism issues with the new API.
  • The parallel versions in functionality are covered by the ComplexIntegrationTest
  • The underlying sources are actually the same for the parallel and non-parallel cases they are just initiated with parallelism one, so I would bother with adding specific test cases for that.

@asfgit asfgit closed this in 145b2ba May 29, 2015
marthavk pushed a commit to marthavk/flink that referenced this pull request Jun 9, 2015
nikste pushed a commit to nikste/flink that referenced this pull request Sep 29, 2015
nltran pushed a commit to nltran/flink that referenced this pull request Jan 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants