[FLINK-11280] [rocksdb] Lazily create RocksDBSerializedCompositeKeyBuilder only after restore #7429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilder only after restore Prior to this commit, the composite key builder was created in the constructor of the RocksDBKeyedStateBackend. The creation of the builder requires providing a key serializer. This is problematic, because the key serializer may be reconfigured during the restore phase, therefore invalidating the key serializer used by the composite key builder. This commit resolves this by lazily creating the composite key builder only after the restore phase, which would be the point-in-time when we are certain the key serializer will no longer be changed and is final.
Contributor
Author
Contributor
|
LGTM now 👍 |
Contributor
Author
|
Thanks, will wait for a green light from Travis. |
…estore in TtlStateTestBase tests
Contributor
Author
|
Travis is green on my local branch: https://travis-ci.org/tzulitai/flink/builds/476821924 Merging ... |
Contributor
Author
|
Merged. Manually closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR fixes the failing test in master:
StateBackendMigrationTestBase.testStateBackendRestoreSucceedsIfNewKeySerializerRequiresReconfiguration.The test reconfigures the key serializer and verifies that the reconfigured version is used instead of the original one. The test fails because when writing keys in the
RocksDBKeyedStateBackend, theRocksDBSerializedCompositeKeyBuilderwas using the invalid, non-reconfigured key serializer.The culprit is that the composite key builder is created in the constructor of the
RocksDBKeyedStateBackend. The creation of the builder requires providing a key serializer.This is problematic, because the key serializer may be reconfigured during the restore phase, therefore invalidating the key serializer used by the composite key builder.
This commit resolves this by lazily creating the composite key builder only after the restore phase, which would be the point-in-time when we are certain the key serializer will no longer be changed and is final.
Verifying this change
The previously failing test
StateBackendMigrationTestBase.testStateBackendRestoreSucceedsIfNewKeySerializerRequiresReconfigurationshould now pass.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation