Skip to content

Conversation

@eaglewatcherwb
Copy link
Contributor

Change-Id: Idb561da3982de07e77a05ffef9ad227094f527b0

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

Brief change log

  • rename configuration options of queryable-state in QueryableStateOptions from query.x to queryable-state.x

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper:no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

…e-state from query.x to queryable-state.x

Change-Id: Idb561da3982de07e77a05ffef9ad227094f527b0
@aljoscha aljoscha self-requested a review January 15, 2019 09:43
Copy link
Contributor

@aljoscha aljoscha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, I'll merge this once Travis is green.

@aljoscha
Copy link
Contributor

Ah, I notifed that some tests in flink-end-to-end-tests still use the old config options. This wouldn't break, because we have the deprecated options still but you should update them as well.

…e-state from query.x to queryable-state.x

in docs, template, and tests

Change-Id: I1c28432cd48c33781a0ff2670155355a743bad12
@eaglewatcherwb
Copy link
Contributor Author

Ah, I notifed that some tests in flink-end-to-end-tests still use the old config options. This wouldn't break, because we have the deprecated options still but you should update them as well.

OK, I update them in the whole project, including docs and template as well.

Change-Id: I3d733cd36298017ef37c72277ce618b35e649a39
@aljoscha
Copy link
Contributor

Thanks for your contribution @eaglewatcherwb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants