[FLINK-11304][docs][table] Fix typo in time attributes doc#7477
Closed
JaryZhen wants to merge 1 commit intoapache:masterfrom
JaryZhen:master
Closed
[FLINK-11304][docs][table] Fix typo in time attributes doc#7477JaryZhen wants to merge 1 commit intoapache:masterfrom JaryZhen:master
JaryZhen wants to merge 1 commit intoapache:masterfrom
JaryZhen:master
Conversation
Contributor
|
Sorry, @hequn8128. I saw your comment too late. I will fix this in a hotfix commit before porting it to the other branches. Thanks. |
asfgit
pushed a commit
that referenced
this pull request
Jan 14, 2019
Author
|
Hi, @twalthr I'd like to know why this PR finished by Closed not Merged ? |
Contributor
Author
|
@twalthr thanks for tell me that. In addition, I noted that only a single rowtime attribute is support at the moment was wrote in sourceSink , so ... I think it's necessary to let user know in this page. |
tisonkun
pushed a commit
to tisonkun/flink
that referenced
this pull request
Jan 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request fix typo in time attributes docs
Brief change log
Fix typo in time attributes doc that DefinedRowtimeAttribute should be DefinedRowtimeAttributes. also, implemented getRowtimeAttributeDescriptors method in doc.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation