[FLINK-11316] [tests] Drop JarFileCreator #7486
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
(Copy from JIRA)
Description
JarFileCreatorTest fails when run with Java 9. Because JarFileCreator is not used in production, the class and its tests can be deleted.
Acceptance Criteria
JarFileCreatorandJarFileCreatorTestare deletedJarFileCreatorinClassLoaderUtilsTest#testWithURLClassLoaderis replaced with an alternativeBrief change log
JarFileCreatorandJarFileCreatorTestJarFileCreatorinClassLoaderUtilsTest#testWithURLClassLoaderwith a specific util method.Verifying this change
Basically it is a trivial code cleanup and we ensure
ClassLoaderUtilsTest#testWithURLClassLoaderstill valid.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation
cc @GJL