Skip to content

Conversation

@hequn8128
Copy link
Contributor

What is the purpose of the change

This pull request fixes errors in tableApi.md and functions.md.

Brief change log

  • Fix example errors in tableApi.md.
  • Add the missing quarters and weeks udf in functions.md for java&scala

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@sunjincheng121 sunjincheng121 self-assigned this Jan 16, 2019
Copy link
Member

@sunjincheng121 sunjincheng121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hequn8128 Thanks for the PR.
I only left one suggestion that we can add the example in the doc. otherwise LGTM.

Bests,
Jincheng

{% endhighlight %}
</td>
<td>
<p>Creates an interval of milliseconds for <i>NUMERIC</i> weeks.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add an example: e.g.:
E.g., 1.weeks returns 604800000 ms.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!

@sunjincheng121
Copy link
Member

sunjincheng121 commented Jan 16, 2019

Thanks for the update! @hequn8128
Add thanks for create the FLINK-11342. pretty cool!
this PR will be merged.
Bests,
Jincheng

@hequn8128
Copy link
Contributor Author

@sunjincheng121 Thanks for the nice suggestion.
I create another issue to address the example problem of built-in udfs. I think it would be very helpful if we have example for every function. Looking forward to have your suggestions.

Best, Hequn

@sunjincheng121
Copy link
Member

Merging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants