-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-11331][table][docs] Fix errors in tableApi.md and functions.md #7494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sunjincheng121
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hequn8128 Thanks for the PR.
I only left one suggestion that we can add the example in the doc. otherwise LGTM.
Bests,
Jincheng
| {% endhighlight %} | ||
| </td> | ||
| <td> | ||
| <p>Creates an interval of milliseconds for <i>NUMERIC</i> weeks.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add an example: e.g.:
E.g., 1.weeks returns 604800000 ms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point!
|
Thanks for the update! @hequn8128 |
|
@sunjincheng121 Thanks for the nice suggestion. Best, Hequn |
37dd76e to
f4494fa
Compare
|
Merging... |
What is the purpose of the change
This pull request fixes errors in
tableApi.mdandfunctions.md.Brief change log
quartersandweeksudf infunctions.mdfor java&scalaVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation