Skip to content

[hotfix] fix typo in MemorySegment#7744

Merged
StefanRRichter merged 1 commit intoapache:masterfrom
leesf:MemorySegmentHotFix
Feb 18, 2019
Merged

[hotfix] fix typo in MemorySegment#7744
StefanRRichter merged 1 commit intoapache:masterfrom
leesf:MemorySegmentHotFix

Conversation

@leesf
Copy link
Copy Markdown
Contributor

@leesf leesf commented Feb 18, 2019

What is the purpose of the change

Fix typo in heapMemory field annotation in MemorySegment.

Brief change log

Fix typo in heapMemory field annotation in MemorySegment

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@flinkbot
Copy link
Copy Markdown
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❌ 1. The [description] looks good.
  • ❌ 2. There is [consensus] that the contribution should go into to Flink.
  • ❔ 3. Needs [attention] from.
  • ❌ 4. The change fits into the overall [architecture].
  • ❌ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot approve description to approve the 1st aspect (similarly, it also supports the consensus, architecture and quality keywords)
  • @flinkbot approve all to approve all aspects
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval

@StefanRRichter
Copy link
Copy Markdown
Contributor

LGTM 👍

@StefanRRichter StefanRRichter merged commit 1d1a6a3 into apache:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants