[FLINK-11678] Clean up ExecutionGraphCache to use ArchivedExecutionGraphs #7769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsBot commandsThe @flinkbot bot supports the following commands:
|
zentol
approved these changes
Feb 20, 2019
Contributor
zentol
left a comment
zentol
left a comment
There was a problem hiding this comment.
+1 for FLINK-11678 commits
@flinkbot approve all
Contributor
Author
Nulling the resourceManagerAddress when suspending the JobMaster prevents that the JobMaster tries to reconnect to the ResourceManager if it receives a disconnectResourceManager message.
…omically This commit makes the suspend call transition the ExecutionGraph atomically into the SUSPENDED state without requiring a round-trip to cancel all task properly. Instead it simply notifies the TaskExecutors about the suspension and then transitions the Executions into a terminal state. Moreover, this commit removes JobStatus#SUSPENDING. This closes apache#7756.
…ableFuture<ArchivedExecutionGraph>
The ExecutionGraphCache now only stores ArchivedExecutionGraphs since it will never receive an ExecutionGraph from the RestfulGateway. - Remove ExecutionGraphTest#testCacheInvalidationIfSuspended - Remove ExecutionGraphTest#testCacheInvalidationIfSwitchToSuspended This closes apache#7769.
tillrohrmann
force-pushed
the
FLINK-11678
branch
from
794621c to
5c63094
Compare
asfgit
pushed a commit
that referenced
this pull request
Feb 20, 2019
The ExecutionGraphCache now only stores ArchivedExecutionGraphs since it will never receive an ExecutionGraph from the RestfulGateway. - Remove ExecutionGraphTest#testCacheInvalidationIfSuspended - Remove ExecutionGraphTest#testCacheInvalidationIfSwitchToSuspended This closes #7769.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Clean up ExecutionGraphCache to use ArchivedExecutionGraphs.
This PR is based on #7756.
Brief change log
Change RestfulGateway#requestJob return type to CompletableFuture.
The ExecutionGraphCache now only stores ArchivedExecutionGraphs since it will never receive an
ExecutionGraph from the RestfulGateway.
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation