Skip to content

Conversation

@zentol
Copy link
Contributor

@zentol zentol commented Feb 20, 2019

Enforce whitespaces around & when used in type definitions, e.g. <T extends T1&T2> would be rejected.

Haven't found a single violation yet, might as well set it in stone. This gets us a step closer to the default checkstyle config, i.e. one special Flink-rule less.

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❌ 1. The [description] looks good.
  • ❌ 2. There is [consensus] that the contribution should go into to Flink.
  • ❔ 3. Needs [attention] from.
  • ❌ 4. The change fits into the overall [architecture].
  • ❌ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot approve description to approve the 1st aspect (similarly, it also supports the consensus, architecture and quality keywords)
  • @flinkbot approve all to approve all aspects
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making our checkstyle stricter @zentol. +1 for merging.

@flinkbot approve all

@zentol zentol merged commit 72dbd1e into apache:master Feb 21, 2019
@zentol zentol deleted the 11688 branch February 22, 2019 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants