Skip to content

Conversation

@Tom-Goong
Copy link
Contributor

What is the purpose of the change

This pull request completes the Chinese translation of "Project Template for Scala" page from official document.

Brief change log

  • Translate the "Project Template for Scala" page into Chinese

Verifying this change

This change is to add a new translated document.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 22, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ✅ 1. The [description] looks good.
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ✅ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@klion26
Copy link
Member

klion26 commented Feb 22, 2019

@Tom-Goong thank you for your contribution, we have to wait until the base pr #7754 has been merged first.

@Tom-Goong
Copy link
Contributor Author

@klion26 Ok, thanks for your comment.
I just started making some simple contributions to the open source project, and the process is still unfamiliar to me. If there is something wrong, let me know. Also, hope that will be more contributions I can do.

@wuchong
Copy link
Member

wuchong commented Apr 20, 2019

Hi @Tom-Goong , thanks for your contribution.

Could you rebase your commit to the latest master? So that We can start to review it.

@Tom-Goong
Copy link
Contributor Author

Hi @wuchong, sorry, i failed to rebase my commit to the first place. so I've checkout a new branch and update origin by force

@wuchong
Copy link
Member

wuchong commented Apr 23, 2019

Thanks @Tom-Goong , I will review it today.

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Tom-Goong for the contribution. The translation quality is very good. I only left some minor comments.

@wuchong
Copy link
Member

wuchong commented Apr 23, 2019

@flinkbot approve-until quality

@wuchong
Copy link
Member

wuchong commented Apr 23, 2019

@flinkbot disapprove quality

@Tom-Goong
Copy link
Contributor Author

Hi, @wuchong , thanks for great help, all comments have been updated.

@wuchong
Copy link
Member

wuchong commented May 5, 2019

LGTM.

Merging...

@asfgit asfgit closed this in 4e505c6 May 5, 2019
@Tom-Goong Tom-Goong deleted the docs-FLINK-11613 branch May 11, 2019 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants