-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-11613][chinese-translation,Documentation]Translate the "Project Template for Scala" page into Chinese #7799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
@Tom-Goong thank you for your contribution, we have to wait until the base pr #7754 has been merged first. |
|
@klion26 Ok, thanks for your comment. |
|
Hi @Tom-Goong , thanks for your contribution. Could you rebase your commit to the latest master? So that We can start to review it. |
|
Hi @wuchong, sorry, i failed to rebase my commit to the first place. so I've checkout a new branch and update origin by force |
|
Thanks @Tom-Goong , I will review it today. |
wuchong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Tom-Goong for the contribution. The translation quality is very good. I only left some minor comments.
|
@flinkbot approve-until quality |
|
@flinkbot disapprove quality |
|
Hi, @wuchong , thanks for great help, all comments have been updated. |
…t Template for Scala" page into Chinese
|
LGTM. Merging... |
What is the purpose of the change
This pull request completes the Chinese translation of "Project Template for Scala" page from official document.
Brief change log
Verifying this change
This change is to add a new translated document.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation