-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-11711][table-planner-blink] Add table and column stats #7838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 19886c4 (Wed Apr 15 11:36:34 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
| * @param maxLen max length of column values, the value is null if not available. | ||
| * (when it's not null, it may be an inaccurate value.) | ||
| * @param max max value of column values, the value is null if not available. | ||
| * (it must be a correct value, and the accurate max value may be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what does "a correct value" mean. I think given a mathematical expression should be clear and sufficient, like "actual max value <= max"
KurtYoung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@flinkbot approve all |
|
@flinkbot disapprove all |
|
Postpone this after #7642 gets merged. |
|
#7642 has been merged. One comment about the package location of |
|
see FLINK-11516 & FLINK-14789 |
What is the purpose of the change
This commit defines the structure of table and column stats which provide statistics for Calcite cost model.
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation