Skip to content

Conversation

@godfreyhe
Copy link
Contributor

What is the purpose of the change

This commit defines the structure of table and column stats which provide statistics for Calcite cost model.

Brief change log

  • add TableStats, ColumnStats and FlinkStatistic

Verifying this change

This change added tests and can be verified as follows:

  • Added unit tests for TableStats, ColumnStats and FlinkStatistic

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (JavaDocs)

@flinkbot
Copy link
Collaborator

flinkbot commented Feb 26, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 19886c4 (Wed Apr 15 11:36:34 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

* @param maxLen max length of column values, the value is null if not available.
* (when it's not null, it may be an inaccurate value.)
* @param max max value of column values, the value is null if not available.
* (it must be a correct value, and the accurate max value may be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what does "a correct value" mean. I think given a mathematical expression should be clear and sufficient, like "actual max value <= max"

Copy link
Contributor

@KurtYoung KurtYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KurtYoung
Copy link
Contributor

@flinkbot approve all

@KurtYoung
Copy link
Contributor

@flinkbot disapprove all

@KurtYoung
Copy link
Contributor

Postpone this after #7642 gets merged.

@twalthr
Copy link
Contributor

twalthr commented Mar 4, 2019

#7642 has been merged. One comment about the package location of TableStats and ColumnStats: Once we expose those classes through table sources, we should think about moving them to another package within flink-table-common. Maybe org.apache.flink.table.statistics?

@godfreyhe
Copy link
Contributor Author

godfreyhe commented Nov 21, 2019

see FLINK-11516 & FLINK-14789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants