[FLINK-11185] Fix StreamSourceOperatorWatermarksTest instability.#7842
Closed
kl0u wants to merge 1 commit intoapache:masterfrom
Closed
[FLINK-11185] Fix StreamSourceOperatorWatermarksTest instability.#7842kl0u wants to merge 1 commit intoapache:masterfrom
kl0u wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsBot commandsThe @flinkbot bot supports the following commands:
|
Contributor
|
This looks good! Can you add the description from this PR to the commit itself? |
Contributor
Author
|
I will. Thanks for the review @aljoscha |
Contributor
Author
|
Can you also accept the PR (for the record) |
tzulitai
pushed a commit
to tzulitai/flink
that referenced
this pull request
Feb 27, 2019
The cause of the instability seems to be that due to a not-so-rare timing, the thread that calls the `interrupt()` on the main thread, runs still after its original test finishes and calls `interrupt()` during execution of the next test. This causes the normal execution (or `sleep()` in this case) to be interrupted. This closes apache#7842.
HuangZhenQiu
pushed a commit
to HuangZhenQiu/flink
that referenced
this pull request
Apr 22, 2019
The cause of the instability seems to be that due to a not-so-rare timing, the thread that calls the `interrupt()` on the main thread, runs still after its original test finishes and calls `interrupt()` during execution of the next test. This causes the normal execution (or `sleep()` in this case) to be interrupted. This closes apache#7842.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change removes the
mainThread.interrupt()call from theStreamSourceOperatorWatermarksTest.testNoMaxWatermarkOnAsyncCancel()test.The cause of the instability seems to be that due to a not-so-rare timing, the thread that calls the
interrupt()on the main thread, runs still after its original test finishes and callinterrupt()during execution of the next test. This causes the normal execution (orsleep()in this case) to be interrupted.