Skip to content

[FLINK-11185] Fix StreamSourceOperatorWatermarksTest instability.#7842

Closed
kl0u wants to merge 1 commit intoapache:masterfrom
kl0u:source-test-instability
Closed

[FLINK-11185] Fix StreamSourceOperatorWatermarksTest instability.#7842
kl0u wants to merge 1 commit intoapache:masterfrom
kl0u:source-test-instability

Conversation

@kl0u
Copy link
Contributor

@kl0u kl0u commented Feb 26, 2019

The change removes the mainThread.interrupt() call from the StreamSourceOperatorWatermarksTest.testNoMaxWatermarkOnAsyncCancel() test.

The cause of the instability seems to be that due to a not-so-rare timing, the thread that calls the interrupt() on the main thread, runs still after its original test finishes and call interrupt() during execution of the next test. This causes the normal execution (or sleep() in this case) to be interrupted.

@kl0u kl0u requested a review from aljoscha February 26, 2019 16:05
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot approve description to approve the 1st aspect (similarly, it also supports the consensus, architecture and quality keywords)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval

@aljoscha
Copy link
Contributor

This looks good! Can you add the description from this PR to the commit itself?

@kl0u
Copy link
Contributor Author

kl0u commented Feb 26, 2019

I will. Thanks for the review @aljoscha

@kl0u
Copy link
Contributor Author

kl0u commented Feb 26, 2019

Can you also accept the PR (for the record)

@asfgit asfgit closed this in 7a5f047 Feb 26, 2019
tzulitai pushed a commit to tzulitai/flink that referenced this pull request Feb 27, 2019
The cause of the instability seems to be that due to a not-so-rare timing,
the thread that calls the `interrupt()` on the main thread, runs still
after its original test finishes and calls `interrupt()` during execution
of the next test. This causes the normal execution (or `sleep()` in this case)
to be interrupted.

This closes apache#7842.
HuangZhenQiu pushed a commit to HuangZhenQiu/flink that referenced this pull request Apr 22, 2019
The cause of the instability seems to be that due to a not-so-rare timing,
the thread that calls the `interrupt()` on the main thread, runs still
after its original test finishes and calls `interrupt()` during execution
of the next test. This causes the normal execution (or `sleep()` in this case)
to be interrupted.

This closes apache#7842.
@kl0u kl0u deleted the source-test-instability branch January 28, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants