Skip to content

Conversation

@aljoscha
Copy link
Contributor

Currently, modules that depend on Hadoop have the version scheme ${project.version}-${hadoop.version}. With this, however, the version does not have SNAPSHOT at the end, meaning we cannot deploy snapshot releases.

The change proposed by @zentol is to use ${hadoop.version}-${project.version}.

I didn't yet see if this is green on Travis, just opening it early for review.

…m to SNAPSHOT guidelines

This also adadpts update_branch_version.sh to correctly update versions
that have a prefix.
@aljoscha aljoscha requested a review from zentol February 28, 2019 11:11
@flinkbot
Copy link
Collaborator

flinkbot commented Feb 28, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ✅ 1. The [description] looks good.
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ✅ 4. The change fits into the overall [architecture].
  • ✅ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot approve description to approve the 1st aspect (similarly, it also supports the consensus, architecture and quality keywords)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval

Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flinkbot approve all

@aljoscha aljoscha closed this Feb 28, 2019
@aljoscha aljoscha deleted the change-hadoop-version-scheme branch February 28, 2019 14:30
@aljoscha
Copy link
Contributor Author

Merged on master, will merge on release-1.8 once it is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants