Skip to content

[FLINK-11801] [table-api] Port SqlParserException to flink-table-api-java#7888

Closed
wuchong wants to merge 1 commit intoapache:masterfrom
wuchong:sql-parse-exception
Closed

[FLINK-11801] [table-api] Port SqlParserException to flink-table-api-java#7888
wuchong wants to merge 1 commit intoapache:masterfrom
wuchong:sql-parse-exception

Conversation

@wuchong
Copy link
Member

@wuchong wuchong commented Mar 4, 2019

What is the purpose of the change

Port SqlParserException to flink-table-api-java

SqlParserException is used in FlinkPlannerImpl for sql parsing. We will have another FlinkPlannerImpl in flink-table-planner-blink.

Because SqlParserException is an API level exception, we should move it to flink-table-api-java to avoid coping it to flink-table-planner-blink.

As @twalthr mentioned in #7886, we would move it to api-java for now, and move to common when it is really required across many different modules.

Brief change log

  • Port SqlParserException to flink-table-api-java

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 4, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ✅ 1. The [description] looks good.
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ✅ 4. The change fits into the overall [architecture].
  • ✅ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @wuchong. +1 to merge. Btw next time you can simply update the PR and JIRA issue to preserve the discussion history.

@flinkbot approve all

@wuchong
Copy link
Member Author

wuchong commented Mar 4, 2019

Thanks @twalthr .

I accidentally pushed the wrong branch to apache/flink, so I have to create a new pull request for this ;-)

@wuchong
Copy link
Member Author

wuchong commented Mar 4, 2019

Will merge this when travis green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants