[FLINK-11801] [table-api] Port SqlParserException to flink-table-api-java#7888
Closed
wuchong wants to merge 1 commit intoapache:masterfrom
Closed
[FLINK-11801] [table-api] Port SqlParserException to flink-table-api-java#7888wuchong wants to merge 1 commit intoapache:masterfrom
wuchong wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Member
Author
|
Thanks @twalthr . I accidentally pushed the wrong branch to apache/flink, so I have to create a new pull request for this ;-) |
Member
Author
|
Will merge this when travis green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Port
SqlParserExceptionto flink-table-api-javaSqlParserExceptionis used inFlinkPlannerImplfor sql parsing. We will have anotherFlinkPlannerImplin flink-table-planner-blink.Because
SqlParserExceptionis an API level exception, we should move it toflink-table-api-javato avoid coping it toflink-table-planner-blink.As @twalthr mentioned in #7886, we would move it to
api-javafor now, and move to common when it is really required across many different modules.Brief change log
SqlParserExceptionto flink-table-api-javaVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation