[FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format#7904
Closed
JingsongLi wants to merge 5 commits intoapache:masterfrom
Closed
[FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format#7904JingsongLi wants to merge 5 commits intoapache:masterfrom
JingsongLi wants to merge 5 commits intoapache:masterfrom
Conversation
…convert internal data format and java format
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
KurtYoung
reviewed
Mar 6, 2019
Contributor
KurtYoung
left a comment
There was a problem hiding this comment.
Thanks for the effort, i have some questions about the responsibility of the converter
...e/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/BinaryArray.java
Show resolved
Hide resolved
...able-runtime-blink/src/main/java/org/apache/flink/table/dataformat/DataFormatConverters.java
Show resolved
Hide resolved
...able-runtime-blink/src/main/java/org/apache/flink/table/dataformat/DataFormatConverters.java
Show resolved
Hide resolved
...able-runtime-blink/src/main/java/org/apache/flink/table/dataformat/DataFormatConverters.java
Show resolved
Hide resolved
wuchong
reviewed
Mar 6, 2019
...able-runtime-blink/src/main/java/org/apache/flink/table/dataformat/DataFormatConverters.java
Outdated
Show resolved
Hide resolved
KurtYoung
reviewed
Mar 6, 2019
...able-runtime-blink/src/main/java/org/apache/flink/table/dataformat/DataFormatConverters.java
Show resolved
Hide resolved
Contributor
Author
|
Hi @KurtYoung @wuchong , thanks for reviewing. I addressed your comments. |
Contributor
|
LGTM, merging... |
HuangZhenQiu
pushed a commit
to HuangZhenQiu/flink
that referenced
this pull request
Apr 22, 2019
…convert between internal data format and java format This closes apache#7904
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Introduce DataFormatConverters java class to convert internal data format and java format
Verifying this change
ut
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation