Skip to content

[FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format#7904

Closed
JingsongLi wants to merge 5 commits intoapache:masterfrom
JingsongLi:converter
Closed

[FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format#7904
JingsongLi wants to merge 5 commits intoapache:masterfrom
JingsongLi:converter

Conversation

@JingsongLi
Copy link
Contributor

What is the purpose of the change

Introduce DataFormatConverters java class to convert internal data format and java format

Verifying this change

ut

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (JavaDocs)

@JingsongLi JingsongLi changed the title Converter [FLINK-11827][table-runtime-blink] Introduce DataFormatConverters to convert internal data format and java format Mar 5, 2019
@flinkbot
Copy link
Collaborator

flinkbot commented Mar 5, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link
Contributor

@KurtYoung KurtYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort, i have some questions about the responsibility of the converter

@JingsongLi
Copy link
Contributor Author

Hi @KurtYoung @wuchong , thanks for reviewing. I addressed your comments.

@KurtYoung
Copy link
Contributor

LGTM, merging...

@KurtYoung KurtYoung closed this in e2579e3 Mar 6, 2019
@JingsongLi JingsongLi deleted the converter branch March 9, 2019 02:31
HuangZhenQiu pushed a commit to HuangZhenQiu/flink that referenced this pull request Apr 22, 2019
…convert between internal data format and java format

This closes apache#7904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants