Skip to content

Conversation

@zentol
Copy link
Contributor

@zentol zentol commented Mar 6, 2019

What is the purpose of the change

This PR merges all daily cron branches into the master. This significantly improves their visibility, makes them easier to maintain as well as simplify the process of running e2e tests for contributors.

cron-master-maven_compat will continue to exist since we only want to run this weekly and we can't have 2 separate cron intervals for the same branch.

Brief change log

  • rework stage selection to be reliant on script parameters instead of implicitly relying on the order of jobs
  • configure existing jobs to only be run for each pr/commit, excluding cron builds
  • merge cron-master-hadoop24
  • merge cron-master-scala212
  • merge cron-master-docs
    • requires additional caching of .rvm so we don't re-download dependencies on every build
    • caching of other builds is not affected
  • merge cron-master-e2e
  • merge cron-master-jdk9
    • modify stage.sh to support excluding modules for which tests currently fail
    • modify travis_mvn_watchdog.sh to not run e2e tests (since they currently fail)

I made no attempts at de-duplicating code in various scripts (like compile calls). Ain't nobody got time for that.

Verifying this change

Clone my branch and setup a cron build. Note that a full build can take a few hours.
I have started a build for this PR: https://travis-ci.org/zentol/flink/builds/502561735

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 6, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@aljoscha
Copy link
Contributor

This looks good to merge. The travis.yml is a bit bloated now but I guess that's what we have to do for now. I'm wondering what's up with the failure in flink-docs, here.

@zentol
Copy link
Contributor Author

zentol commented Mar 20, 2019

The PR is probably based on a broken master, rebasing and re-running travis to be sure.

@zentol zentol merged commit 9ffd931 into apache:master Mar 20, 2019
@zentol zentol deleted the 11786 branch March 21, 2019 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants