Skip to content

Conversation

@chunhui-shi
Copy link

##What is the purpose of the change
As part of native kubernetes integration. Introduce client wrapper to access Kubernetes service.

##Brief change log

  • _Implement KubeClient interface and actual implementation.
  • _Add mock kube server which is derived from Fabric's mock implementation.
  • _A unit tests of KubeClient.

##Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @public(Evolving): ( no)
  • The serializers: (no )
  • The runtime per-record code paths (performance sensitive): ( no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no )
  • The S3 file system connector: ( no )
    ##Documentation
  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (the document will be introduced in later pull requests)

chunhui-shi and others added 3 commits March 1, 2019 17:26
…mpty implementation

Include Kubernetes Cluster entrypoint with abstract kubernetes client

Co-authored-by: Chunhui Shi <cshi@apache.org>
Co-authored-by: Jin Sun <isunjin@gmail.com>
Co-authored-by: Chunhui Shi <cshi@apache.org>
Co-authored-by: Jin Sun <isunjin@gmail.com>
…netes clients

Add tests based on Kubernetes Mock server

Implement Kubernetes Cluster entrypoint with abstract kubernetes client

Co-authored-by: Chunhui Shi <cshi@apache.org>
Co-authored-by: Jin Sun <isunjin@gmail.com>
@flinkbot
Copy link
Collaborator

flinkbot commented Mar 8, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 354ff96 (Sat Aug 28 13:07:50 UTC 2021)

Warnings:

  • 2 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@chunhui-shi
Copy link
Author

This is the second pull request coming after #7844.

@tillrohrmann
Copy link
Contributor

There is a dependency convergence error. Please fix this error @chunhui-shi.

@tianchen92
Copy link
Contributor

tianchen92 commented Jun 4, 2019

This PR is outdated, see #8659

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 8, 2019

CI report for commit 354ff96: FAILURE Build

@wangyang0918
Copy link
Contributor

Close this PR since it is already supported for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants