Skip to content

Conversation

@carp84
Copy link
Member

@carp84 carp84 commented Mar 13, 2019

What is the purpose of the change

  • This PR is a document refinement for end-to-end tests.

Brief change log

  • Correct the markdown syntax error so as to show the flink dir meaning clearly.
  • Add note to prevent user run the nightly script with explicit bash command.

Verifying this change

This change is a document refinement without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 13, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ✅ 1. The [description] looks good.
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ✅ 4. The change fits into the overall [architecture].
  • ✅ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@sunjincheng121
Copy link
Member

@flinkbot approve description
@flinkbot approve consensus

@sunjincheng121
Copy link
Member

Thanks for the quick and nice fix! @carp84
The changes LGTM.
Merging ...
@flinkbot approve all

sunjincheng121 pushed a commit to sunjincheng121/flink that referenced this pull request Mar 13, 2019
@asfgit asfgit closed this in 884d26b Mar 13, 2019
asfgit pushed a commit that referenced this pull request Mar 13, 2019
@carp84
Copy link
Member Author

carp84 commented Mar 13, 2019

Thanks for review @sunjincheng121 !

HuangZhenQiu pushed a commit to HuangZhenQiu/flink that referenced this pull request Apr 22, 2019
sunhaibotb pushed a commit to sunhaibotb/flink that referenced this pull request May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants