-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-11820][serialization] SimpleStringSchema handle message record which value is null #7987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
|
Nice catch, and thank you for your contribution @lamber-ken. we should avoid I not every sure whether we have to add a ut for this. |
|
@klion26, I see, thanks. |
… which value is null
|
@klion26, hi, I have updated the pr as you suggest, thanks |
|
@klion26,cc |
|
thanks for you contribution, LGTM now |
|
Hi! Quick message to say that we hit the same problem this week, and applied a similar patch that mitigated the issue. |
|
hi, @GJL @tillrohrmann, this pr fix NPE in some scenarioscan, can you take a look here? Thanks. |
flink-core/src/test/java/org/apache/flink/api/common/serialization/SimpleStringSchemaTest.java
Show resolved
Hide resolved
flink-core/src/main/java/org/apache/flink/api/common/serialization/SimpleStringSchema.java
Show resolved
Hide resolved
|
Hi @GJL, Thanks for your review and your comment is great for me. But my branch has been deleted unexpectly, so I can't commit anything, need I open a new PR? |
|
@lamber-ken I think yes. You can try to recover the commits via: https://help.github.com/en/articles/checking-out-pull-requests-locally |
@GJL, I open a new PR, and update it as your comment, see #8583 |
What is the purpose of the change
when kafka msg queue contains some records which value is null,
SimpleStringSchemacan't process these records.for example, msg queue like bellow.
for normal, use SimpleStringSchema to process msg queue data
but, will get NullPointerException