[FLINK-11871][table-runtime-blink] Introduce LongHybridHashTable to improve performance when join key fits in long #7996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mprove performance when join key fits in long
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Contributor
Author
|
cc @JingsongLi |
JingsongLi
reviewed
Mar 19, 2019
Contributor
JingsongLi
left a comment
JingsongLi
left a comment
There was a problem hiding this comment.
Thanks for opening a PR for this @KurtYoung , LGTM +1 , left some minor comments.
| if (curSegRemain > 0) { | ||
| int copySize = Math.min(curSegRemain, sizeInBytes); | ||
|
|
||
| byte[] bytes = new byte[copySize]; |
Contributor
There was a problem hiding this comment.
get bytes from allocateReuseBytes or add TODO?
Contributor
Author
There was a problem hiding this comment.
i think allocate reuse bytes make sense
| } | ||
| } | ||
|
|
||
| // public void append(long key, BinaryRow row) throws IOException { |
Contributor
Author
|
@JingsongLi Thanks for the reviewing, i will address the comments and merge this later. |
HuangZhenQiu
pushed a commit
to HuangZhenQiu/flink
that referenced
this pull request
Mar 20, 2019
…mprove performance when join key fits in long This closes apache#7996
HuangZhenQiu
pushed a commit
to HuangZhenQiu/flink
that referenced
this pull request
Apr 22, 2019
…mprove performance when join key fits in long This closes apache#7996
sunhaibotb
pushed a commit
to sunhaibotb/flink
that referenced
this pull request
May 8, 2019
…mprove performance when join key fits in long This closes apache#7996
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
We can do further optimizations if we know the join key fits in long, a single long field or two integer fields are both ok. For example, we can combine the hash code and actual key into one field, there will be no hash collision, can save a lot of unnecessary logic.
Brief change log
Verifying this change
This change added some unit tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation