Skip to content

Conversation

@tweise
Copy link
Contributor

@tweise tweise commented Mar 21, 2019

Backport from master.

@tweise tweise requested review from aljoscha and zentol March 21, 2019 18:17
@flinkbot
Copy link
Collaborator

flinkbot commented Mar 21, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ✅ 1. The [description] looks good.
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ✅ 4. The change fits into the overall [architecture].
  • ✅ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@jgrier
Copy link
Member

jgrier commented Mar 22, 2019

@flinkbot approve all

@jgrier
Copy link
Member

jgrier commented Mar 22, 2019

lgtm

@tweise tweise merged commit 11af452 into apache:release-1.8 Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants