Skip to content

[FLINK-11153][dataset] Remove UdfAnalyzer #8041

Merged
zentol merged 2 commits intoapache:masterfrom
zentol:11153
Mar 27, 2019
Merged

[FLINK-11153][dataset] Remove UdfAnalyzer #8041
zentol merged 2 commits intoapache:masterfrom
zentol:11153

Conversation

@zentol
Copy link
Contributor

@zentol zentol commented Mar 24, 2019

What is the purpose of the change

This PR removes the UdfAnalyzer and related code. This feature is not working under Java 9, and was pretty much a rather hidden experimental feature to begin with.

Related annotations and methods in the ExecutionConfig are now deprecated and have no effect. The PublicEvolving exceptions have been removed as I deem it unlikely that a user actually relies on them.

We can now run the flink-java tests on Java 9 without failure, as shown here: https://travis-ci.org/zentol/flink/builds/510393063

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 24, 2019

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ✅ 1. The [description] looks good.
  • ✅ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@twalthr
Copy link
Contributor

twalthr commented Mar 26, 2019

@flinkbot approve-until consensus

Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zentol. I just had a minor comment. Otherwise +1 to merge.

* - Warnings if a tuple access uses a wrong index
* - Information about the number of object creations (for manual optimization)
*
* @deprecated The code analysis code has been removed and this enum has no effect.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the mentioning of this in the class JavaDoc of ExecutionConfig.

@zentol zentol merged commit 6f07560 into apache:master Mar 27, 2019
@zentol zentol deleted the 11153 branch March 27, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants