-
Notifications
You must be signed in to change notification settings - Fork 13.9k
[FLINK-12054][Tests] HBaseConnectorITCase fails on Java 9 #8079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
zentol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flinkbot approve description
| private static void addDirectoryToClassPath(File directory) { | ||
| try { | ||
| // Get the classloader actually used by HBaseConfiguration | ||
| ClassLoader classLoader = HBaseConfiguration.create().getClassLoader(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point of this method is to mutate the default classloader so that the hbase-site.xml is on the classpath later on.
By creating a new classloader that is immediately discarded once the method exists and never used to actually load anything this method becomes a no-op, which isn't acceptable.
|
@zentol hi, Chesnay. Sorry to bother you, could you please tell me the reason you closed this PR. |
|
@leesf Your solution at the time did not fix the problem as I out-lined in my comment and you didn't respond to it. I now see that you made another attempt, but it yet again does not work. This is especially concerning since the very same comment on your first solution still applies to your second one. Pull requests are not a public WIP branch, they are to be used for providing, at the very least, working solutions. Please go back to the JIRA, thoroughly analyze the problem, provide&discuss solutions and verify them, before opening another PR. |
What is the purpose of the change
Fix the error in HBaseConnectorITCase on Java 9.
Brief change log
Create a new URLClassLoader with directory.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation