Skip to content

Conversation

@yinchuanwang
Copy link

  1. Rename the section title from standalone to Flink session cluster on Mesos.
  2. Add one new section Flink job cluster on Mesos which describes the usage of mesos-appmaster-job.sh.

What is the purpose of the change

This pull request adds the documentation for mesos-appmaster-job.sh.

Brief change log

  • Rename the existing section title from 'standalone' to 'Flink session cluster on Mesos' to be consistent with its content.
  • Add one new section 'Flink job cluster on Mesos' to describe the usage of mesos-appmaster-job.sh.

Verifying this change

This change is a trivial documentation enhancement without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

1. Rename the section title from `standalone` to `Flink session cluster on Mesos`.
2. Add one new section `Flink job cluster on Mesos` which describes the usage of mesos-appmaster-job.sh.
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@yinchuanwang yinchuanwang changed the title [FLINK-12020] [docs] Add documentation for mesos-appmaster-job.sh [FLINK-12020] [Deployment/Mesos/Documentation] Add documentation for mesos-appmaster-job.sh Apr 2, 2019
@tillrohrmann tillrohrmann self-assigned this Apr 2, 2019
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the update of the documentation @yinchuanwang. LGTM. Merging.

asfgit pushed a commit that referenced this pull request Apr 2, 2019
1. Rename the section title from `standalone` to `Flink session cluster on Mesos`.
2. Add one new section `Flink job cluster on Mesos` which describes the usage of mesos-appmaster-job.sh.

This closes #8084.
@asfgit asfgit closed this in b36bca8 Apr 2, 2019
asfgit pushed a commit that referenced this pull request Apr 2, 2019
1. Rename the section title from `standalone` to `Flink session cluster on Mesos`.
2. Add one new section `Flink job cluster on Mesos` which describes the usage of mesos-appmaster-job.sh.

This closes #8084.
HuangZhenQiu pushed a commit to HuangZhenQiu/flink that referenced this pull request Apr 22, 2019
1. Rename the section title from `standalone` to `Flink session cluster on Mesos`.
2. Add one new section `Flink job cluster on Mesos` which describes the usage of mesos-appmaster-job.sh.

This closes apache#8084.
sunhaibotb pushed a commit to sunhaibotb/flink that referenced this pull request May 8, 2019
1. Rename the section title from `standalone` to `Flink session cluster on Mesos`.
2. Add one new section `Flink job cluster on Mesos` which describes the usage of mesos-appmaster-job.sh.

This closes apache#8084.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants