Skip to content

Conversation

@aljoscha
Copy link
Contributor

No description provided.

@aljoscha aljoscha requested a review from zentol April 10, 2019 09:10
@aljoscha
Copy link
Contributor Author

When I merged this, I'll also merge it on release-1.8, right?

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@zentol
Copy link
Contributor

zentol commented Apr 10, 2019

afaik this should only be merged to master, for which you've got my +1.

@zentol
Copy link
Contributor

zentol commented Apr 10, 2019

now that I think about it though, that would mean that, if a Public API was added in 1.8.0, we could remove it in 1.8.1 again. curious...

@aljoscha aljoscha force-pushed the update-japicmp-1.8.0 branch from 8822049 to 3e89ffa Compare April 10, 2019 10:58
@aljoscha
Copy link
Contributor Author

That's why I thought adding it to release-1.8 would also make sense.

@zentol
Copy link
Contributor

zentol commented Apr 10, 2019

OK, let's think this through properly.

The 1.X.0 release compares against the last 1.(X-1).Z release.
The release-1.X branches always compare against the latest 1.X.Y release.

This creates a tree structure, with the latest releases always being leaf nodes.

A -> B : B checks compatibility against A

1.6.0 -> 1.6.1 -> 1.6.2 -> ...
            \-> 1.7.0 -> 1.7.1 -> 1.7.2 -> 1.7.3
                   \-> 1.8.0 -> 1.8.1 -> 1.8.2 ...

Can there be incompatible changes between leaf nodes, i.e. 1.6.3 and 1.7.3, without this breaking other incompatibilities?
I think one case might be that 1.6.4 adds a new Public API, but 1.7.3 adds a different version of this API.

My conclusion would be that we have to run the check twice; against the latest version in the previous series as well as the latest version in the current series.

1.6.0 -> 1.6.1 -> 1.6.2 ---------------\
            \-> 1.7.0 -> 1.7.1 -> 1.7.2 -> 1.7.3 -/
                   \-> 1.8.0 -> 1.8.1 -> 1.8.2 <-/

@aljoscha
Copy link
Contributor Author

merged

@aljoscha aljoscha closed this Apr 10, 2019
@aljoscha aljoscha deleted the update-japicmp-1.8.0 branch April 10, 2019 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants