Skip to content

Conversation

@zentol
Copy link
Contributor

@zentol zentol commented Apr 11, 2019

What is the purpose of the change

Fixes an issue in the FlinkILoopTest where the test failed on Java 9.

From my understanding, powermock loads classes in a separate classloader during mocking. However powermock does not account for Java 9 modules (see powermock/powermock#864), due to which the loading will fail if the class is not available by default on java 9, as is the case for javax classes.

Apparently the PowerMockIgnore annotation stops powermock from separately loading the class, and thus the test can pass.

Verifying this change

I ran the test successfully on java 9 on a dev branch: https://travis-ci.org/zentol/flink/jobs/518712231

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @zentol. +1 for merging.

@zentol zentol merged commit 9438147 into apache:master Apr 17, 2019
@zentol zentol deleted the 12102 branch April 17, 2019 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants