Skip to content

Conversation

@yanghua
Copy link
Contributor

@yanghua yanghua commented Apr 11, 2019

What is the purpose of the change

This pull request updates FlinkKafkaConsumerBaseMigrationTest for 1.8

Brief change log

(for example:)

  • Update FlinkKafkaConsumerBaseMigrationTest for 1.8

Verifying this change

This change is already covered by existing tests, such as FlinkKafkaConsumerBaseMigrationTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@zentol
Copy link
Contributor

zentol commented Apr 11, 2019

@yanghua can you do me a favor and bundle all tests that you update in a single PR? It's all the same stuff, let's do this in one go.

@yanghua
Copy link
Contributor Author

yanghua commented Apr 11, 2019

@zentol OK, my plan is open a single PR for the umbrella issue then one subtask one commit. What do you think?

@zentol
Copy link
Contributor

zentol commented Apr 11, 2019

@yanghua sounds good!

@yanghua
Copy link
Contributor Author

yanghua commented Apr 14, 2019

@zentol Thanks for your suggestion. I have reopened a new PR #8168 for the migration test umbrella issue, this PR's commit has been cherry-picked into that PR. So closing this PR.

@yanghua yanghua closed this Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants