Skip to content

[FLINK-12169] [javadocs] improve javadoc of MessageAcknowledgingSource… #8155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
knaufk wants to merge 1 commit into from
Closed

[FLINK-12169] [javadocs] improve javadoc of MessageAcknowledgingSource… #8155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .../java/org/apache/flink/streaming/api/functions/source/MessageAcknowledgingSourceBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,9 @@
* while (running) {
* Message msg = queue.retrieve();
* synchronized (ctx.getCheckpointLock()) {
* ctx.collect(msg.getMessageData());
* addId(msg.getMessageId());
* if (addId(msg.getMessageId())) {
* ctx.collect(msg.getMessageData());
* }
* }
* }
* }
Expand Down Expand Up @@ -187,7 +188,8 @@ public void close() throws Exception {
protected abstract void acknowledgeIDs(long checkpointId, Set<UId> uIds);

/**
* Adds an ID to be stored with the current checkpoint.
* Adds an ID to be stored with the current checkpoint. In order to achieve exactly-once guarantees, implementing
* classes should only emit records with IDs for which this method return true.
* @param uid The ID to add.
* @return True if the id has not been processed previously.
*/
Expand Down